Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing includes of standard headers. #2012

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix missing includes of standard headers. #2012

merged 1 commit into from
Sep 18, 2023

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Sep 18, 2023

This is adding all the standard headers missing in an attempt to see if this fixes #2013 ... it does not ( #2014 fixed it)
However, can't harm to have this more clean anyway :)

While at it, update the current expectations in the smoke tests.

@hzeller hzeller changed the title Fix missing includes of stanard headers. Fix missing includes of standard headers. Sep 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ccbe173) 92.85% compared to head (d5d3fdf) 92.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2012   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files         357      357           
  Lines       26399    26399           
=======================================
  Hits        24512    24512           
  Misses       1887     1887           
Files Changed Coverage Δ
common/analysis/citation.cc 100.00% <ø> (ø)
common/analysis/command_file_lexer.cc 83.33% <ø> (ø)
common/analysis/file_analyzer.cc 96.84% <ø> (ø)
common/analysis/file_analyzer.h 100.00% <ø> (ø)
common/analysis/lint_rule_status.cc 96.92% <ø> (ø)
common/analysis/lint_waiver.cc 93.51% <ø> (ø)
common/analysis/lint_waiver.h 100.00% <ø> (ø)
common/analysis/linter_test_utils.cc 96.15% <ø> (ø)
common/analysis/linter_test_utils.h 97.87% <ø> (ø)
common/analysis/violation_handler.cc 93.57% <ø> (ø)
... and 110 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hzeller hzeller requested a review from fangism September 18, 2023 21:23
Copy link
Collaborator

@fangism fangism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup

@hzeller hzeller merged commit 470e0b9 into chipsalliance:master Sep 18, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI currently not working - compiler installation issue ?
3 participants